Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CIT - Corregir la creación de agendas no nominalizadas #3082

Merged
merged 1 commit into from
Oct 22, 2024
Merged

CIT - Corregir la creación de agendas no nominalizadas #3082

merged 1 commit into from
Oct 22, 2024

Conversation

aldoEMatamala
Copy link
Contributor

@aldoEMatamala aldoEMatamala commented Oct 9, 2024 •
edited
Loading

Requerimiento

https://proyectos.andes.gob.ar/browse/CIT-286

Funcionalidad desarrollada

  1. Se agregan modals en las siguientes situaciones
  • Cuando empiezo a cargar prestaciones nominalizadas y cargo una no-nominalizada, eliminandose del listado esta última
  • Cuando cargo una prestación no-nominalizada y cargo una nominalizada, eliminandose del listado esta última

UserStory llegó a completarse

  • Si
  • No
  • No corresponde

Requiere actualizaciones en la base de datos

  • Si
  • No

Requiere actualizaciones en la API

  • Si
  • No

Requiere actualizaciones en andes-test-integracion

  • Si
  • No

@aldoEMatamala aldoEMatamala requested review from a team as code owners October 9, 2024 12:21
@aldoEMatamala
Copy link
Contributor Author

image

@aldoEMatamala aldoEMatamala added the test ok Los test estan ok label Oct 9, 2024
MarianoCampetella
MarianoCampetella approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@MarianoCampetella MarianoCampetella left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A modo de recordatorio, utilizar variables mas explicitas en las lineas 405 y 406 de "planificar-agenda.component.ts" para hacer mas legible el código. El resto se encuentra funcionando correctamente!

@negro89 negro89 merged commit 38af5be into master Oct 22, 2024
2 checks passed
@negro89 negro89 deleted the CIT-286 branch October 22, 2024 18:47
liquid36 pushed a commit that referenced this pull request Oct 23, 2024
@semantic-release-bot
chore(release): 5.151.0 [skip ci]
50b0b9f 
# [5.151.0](v5.150.0...v5.151.0) (2024-10-23)

### Bug Fixes

* **CIT-286:** Corregir la creación de agendas no nominalizadas ([#3082](#3082)) ([38af5be](38af5be))
* **CITAS:** actualiza carpetaEfectores en el turno ([#3084](#3084)) ([c07279d](c07279d))
* **CITAS:** se corrige error al dar turno en demanda rechazada ([#3087](#3087)) ([9ec841e](9ec841e))
* **RUP:** agendas mias/todas ([#3083](#3083)) ([a15bd75](a15bd75))

### Features

* **GDU:** quita restricción para usuario temporal en edición de email ([#3089](#3089)) ([e25e123](e25e123))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AgosLizzi AgosLizzi AgosLizzi approved these changes

@MarianoCampetella MarianoCampetella MarianoCampetella approved these changes

@MCele MCele Awaiting requested review from MCele MCele is a code owner automatically assigned from andes/code-review

Assignees
No one assigned
Labels
Aprobado test ok Los test estan ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aldoEMatamala @MarianoCampetella @AgosLizzi @negro89